Skip to content

Fix type hints for add_collection #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type hints for add_collection #1023

wants to merge 1 commit into from

Conversation

jamesmyatt
Copy link

Fixes mypy errors

Replaces #1012

@jamesmyatt jamesmyatt mentioned this pull request Feb 13, 2025
Closed
krepysh
krepysh approved these changes Mar 7, 2025
View reviewed changes
Copy link

@krepysh krepysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krepysh krepysh krepysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesmyatt @krepysh